On Thu, 8 Jan 2026 07:11:30 GMT, Daniel Jeliński <[email protected]> wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> create the script and css files only if not already present
>
> test/failure_handler/src/share/classes/jdk/test/failurehandler/HtmlPage.java
> line 96:
>
>> 94: }
>> 95: final String content = """
>> 96: function doShow(e) {
>
> Would it be possible to check in the css/js files to the repository instead
> of generating them on the fly?
Hello Daniel, that's possible to do. These files would then need to be looked
up (ClassLoader.getResourceAsStream(...)) and then copied over to the relevant
runtime `dir`(s) as and when needed by the failure handler. So there will still
be a step of copying these files.
It does prevent the inline js/css text we have in these java source files. Is
that inline script/css content you suggest we avoid (for better error detection
and code completion in IDEs)?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29106#discussion_r2671187017
