On Thu, 8 Jan 2026 07:37:45 GMT, David Holmes <[email protected]> wrote:
>> Yes. Having the js and css in separate files has several advantages: you can >> find the files using their file names, you have IDE support when editing, >> and if you fix a bug directly in the generated js file, you can copy the >> entire file instead of copying its contents back to the generator. >> >> Not a blocker for this PR anyway; I don't expect anyone to work on these >> files anytime soon. > > I think that would overcomplicate things for the various "failure" handlers > ... > Yes. Having the js and css in separate files has several advantages: you can > find the files using their file names, you have IDE support when editing, and > if you fix a bug directly in the generated js file Understood. > Not a blocker for this PR anyway; I don't expect anyone to work on these > files anytime soon. I agree that the changes to this code is going to be rare. I'll consider this suggestion of moving the content to a separate version controlled file for a future PR then. I would have tried it now, but there is one internal failure handler which I am not yet conversant with and I don't know if it will complicate things in that code. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29106#discussion_r2671622490
