On Mon, 20 Apr 2026 08:17:10 GMT, Thomas Stuefe <[email protected]> wrote:
>> Coleen Phillimore has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains four additional >> commits since the last revision: >> >> - Reworked OMT/COH warning to always warn with -OMT and +COH. Fixed build >> --enable-cds-archive-coh to nocoh. >> - Update test/hotspot/jtreg/runtime/CommandLine/VMOptionWarning.java >> >> Co-authored-by: Fredrik Bredberg <[email protected]> >> - Add warning about incompatible COH with OMT. >> - Make UseCompactObjectHeaders the default and adjust CDS archives. > > src/hotspot/share/runtime/arguments.cpp line 3784: > >> 3782: #ifdef _LP64 >> 3783: if (UseCompactObjectHeaders && !UseObjectMonitorTable) { >> 3784: // Warn if -UseCompactObjectHeaders is not on the command line, in >> order to turn off UseObjectMonitorTable. > > The comment is a bit confusing, and arguably redundant, since it just states > what the code below, including printout, make already clear. I'd just remove > the comment. Always happy to remove confusing and redundant comments. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30322#discussion_r3130508194
