On Mon, 11 May 2026 21:03:19 GMT, Coleen Phillimore <[email protected]> wrote:

>> This change makes UseCompactObjectHeaders default and switches the sense of 
>> the CDS archive naming.  Now classes.jsa is with UseCompressedOops + 
>> UseCompactObjectHeaders (both default).  Then theres:
>> classes_nocoops.jsa
>> classes_nocoh.jsa
>> classes_nocoops_nocoh.jsa
>> 
>> Hopefully someday we won't need the nocoh versions.
>> 
>> Tested with tier1-8.  With only one issue also fixed in this change, and no 
>> other new issues found.
>> 
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Coleen Phillimore has updated the pull request with a new target base due to 
> a merge or a rebase. The incremental webrev excludes the unrelated changes 
> brought in by the merge/rebase. The pull request contains six additional 
> commits since the last revision:
> 
>  - Merge branch 'master' into coh-default
>  - Fix CDSPluginTest and remove comment.
>  - Reworked OMT/COH warning to always warn with -OMT and +COH.  Fixed build 
> --enable-cds-archive-coh to nocoh.
>  - Update test/hotspot/jtreg/runtime/CommandLine/VMOptionWarning.java
>    
>    Co-authored-by: Fredrik Bredberg <[email protected]>
>  - Add warning about incompatible COH with OMT.
>  - Make UseCompactObjectHeaders the default and adjust CDS archives.

make/Images.gmk line 145:

> 143:   # enable and also explicitly disable coh as needed.
> 144:   ifeq ($(call isTargetCpuBits, 64), true)
> 145:     $1_$2_NOCOH_OPTION := -XX:+UnlockExperimentalVMOptions \

Comments in this section still refers to _coh and not _nocoh.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/30322#discussion_r3224413095

Reply via email to