On Mon, 4 May 2026 13:14:49 GMT, Erik Joelsson <[email protected]> wrote:
>> Seems there are quite a few of UTIL_ARG_ENABLE without an IF_ENABLD part, >> e.g. >> https://github.com/openjdk/jdk/blob/3a657644b396f33cddc987b8f659225ca4f4b49c/make/autoconf/jdk-options.m4#L187 > > This was not what I meant. I want `OBJCOPY_COMPRESS_FLAGS` to be defined here > in configure and exported through spec.gmk instead of a boolean value. > > Yes, there are other JDK options that result in just a bool variable. The > design depends on the option. We try to define flag values in configure, so > in this case doing that makes more sense than a bool value. > `UNLIMITED_CRYPTO` does not evaluate into a simple set of flags, so is not a > good representative option to model this new option after. I set now in the latest rev `IF_ENABLED: [ ENABLE_OBJCOPY_DEBUGINFO_COMPRESSION="true" ])` Should I add something like `IF_DISABLED: [ ENABLE_OBJCOPY_DEBUGINFO_COMPRESSION="false" ])` ? Or set OBJCOPY_COMPRESS_FLAGS in the new UTIL_ARG_ENABLE block ? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30971#discussion_r3181877514
