On Mon, 4 May 2026 13:29:42 GMT, Matthias Baesken <[email protected]> wrote:
>> This was not what I meant. I want `OBJCOPY_COMPRESS_FLAGS` to be defined >> here in configure and exported through spec.gmk instead of a boolean value. >> >> Yes, there are other JDK options that result in just a bool variable. The >> design depends on the option. We try to define flag values in configure, so >> in this case doing that makes more sense than a bool value. >> `UNLIMITED_CRYPTO` does not evaluate into a simple set of flags, so is not a >> good representative option to model this new option after. > > I set now in the latest rev > `IF_ENABLED: [ ENABLE_OBJCOPY_DEBUGINFO_COMPRESSION="true" ])` > > Should I add something like > `IF_DISABLED: [ ENABLE_OBJCOPY_DEBUGINFO_COMPRESSION="false" ])` > ? > > Or set OBJCOPY_COMPRESS_FLAGS in the new UTIL_ARG_ENABLE block ? Yes, set OBJCOPY_COMPRESS_FLAGS in the IF_ENABLED block and export that variable in through spec. (Setting ENABLE_OBJCOPY_DEBUGINFO_COMPRESSION in the IF_ENABLED/IF_DISABLED block serves no purpose, that is done automatically by the UTIL_ARG_ENABLE anyway.) ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30971#discussion_r3181922022
