On Wed, 13 May 2026 18:49:53 GMT, Stefan Karlsson <[email protected]> wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix comments for nocoh in Images.gmk.
>
> test/hotspot/jtreg/runtime/CommandLine/VMOptionWarning.java line 79:
>
>> 77: */
>> 78:
>> 79: /* @test VMOptionWarningCompactObjectHeaders
>
> This has the same string as the run block above. Is that a bug? Also, other
> tests use id=<various descriptive identifiers>. Is the above a short-hand for
> that, or is this missing the id= part?
typo, that should be VMOptionWarningUsseObjectMonitorTable
> test/jdk/tools/jlink/plugins/CDSPluginTest.java line 82:
>
>> 80: boolean NOCOMPACT_HEADERS = Platform.is64bit() &&
>> 81:
>> wb.getBooleanVMFlag("UseCompactObjectHeaders") &&
>> 82:
>> !wb.isDefaultVMFlag("UseCompactObjectHeaders");
>
> Is this correct? It seems to set NOCOMPACT_HEADERS to true if someone has
> explicitly used -XX:+UseCompactObjectHeaders
The CDSPlugin helper wasn't generating the nocoh archives, which is why I
removed the nocoh version of the test initially. I fixed the that instead.
The test will look for _nocoh if that option is given on the command line, but
CDSPlugin.java will generate all 4 archives.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30322#discussion_r3237097498
PR Review Comment: https://git.openjdk.org/jdk/pull/30322#discussion_r3237094539
