On Thu, 21 May 2026 09:13:44 GMT, SendaoYan <[email protected]> wrote:

>> Yasumasa Suenaga has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Drop IA32 support
>
> make/devkit/Tools.gmk line 373:
> 
>> 371: # Create a TARGET bfd + libiberty only.
>> 372: # Configure one or two times depending on mulitlib arch.
>> 373: # If multilib, the second should be 32-bit, and we resolve
> 
> Does this comment needed

I'm not sure whether we can remove it so far.

I know you mentioned for the comment for BFD, but configure options for GCC, 
following architectures do not need to support 32 bit, in other words, other 
archs (e.g. aarch64) multilib might be enabled.


ifneq ($(filter riscv64 ppc64le s390x x86_64, $(ARCH)), )
  # We only support 64-bit on these platforms anyway
  CONFIG += --disable-multilib
endif

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/31227#discussion_r3327955886

Reply via email to