On Sat, 30 May 2026 03:30:17 GMT, Yasumasa Suenaga <[email protected]> wrote:
>> make/devkit/Tools.gmk line 373: >> >>> 371: # Create a TARGET bfd + libiberty only. >>> 372: # Configure one or two times depending on mulitlib arch. >>> 373: # If multilib, the second should be 32-bit, and we resolve >> >> Does this comment needed > > I'm not sure whether we can remove it so far. > > I know you mentioned for the comment for BFD, but configure options for GCC, > following architectures do not need to support 32 bit, in other words, other > archs (e.g. aarch64) multilib might be enabled. > > > ifneq ($(filter riscv64 ppc64le s390x x86_64, $(ARCH)), ) > # We only support 64-bit on these platforms anyway > CONFIG += --disable-multilib > endif No, we only ever did a working multilib for x86. In my experience, multilib for arm is far from as ubiquitous, so IMO not something we need to try to support. Especially since it has likely never been confirmed to work through these makefiles. If we are removing the multilib support for x86, we should get rid of it completely to reduce unnecessary complexity in these makefiles. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31227#discussion_r3357804401
