On Mon, 30 Mar 2026 16:18:04 GMT, Andrew Haley <[email protected]> wrote:

>> src/hotspot/share/compiler/compiler_globals.hpp line 391:
>> 
>>> 389:           "information at the bailout point")                          
>>>      \
>>> 390:                                                                        
>>>      \
>>> 391:   product(int, ProfileCaptureRatio, 1, EXPERIMENTAL,                   
>>>      \
>> 
>> Put it at `64`, if you believe this is a right tradeoff.
>
> This is an experimental patch. I don't think I should turn an experiment on 
> by default.

OK, but if you are keeping `PCR == 1` by default, this means none of the newly 
introduced paths are tested regularly, and are subject to bitrot. At very least 
add a HelloWorld-style jtreg test that passes with higher `PCR`? Maybe even 
with the whole 2^n range of `PCR`-s?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28541#discussion_r3414204924

Reply via email to