On Thu, 25 Jun 2026 21:17:15 GMT, Mikael Vidstedt <[email protected]> wrote:
> Implementation of the JEP to deprecate the macOS/x64 port for removal. Note > that the JEP is still in Submitted state. Meanwhile, I'm opening this PR for > awareness and for your help reviewing the proposed changes. > > In particular, I could use your help making sure the change to GHA > (`main.yml`) does the right thing. The intention is to allow running > macOS/x64 builds/tests, but to not include the port by default. > > --------- > - [X] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). Seems reasonable. Can't comment on the GHA part though. One query below. make/autoconf/platform.m4 line 663: > 661: AC_ARG_ENABLE(deprecated-ports, > [AS_HELP_STRING([--enable-deprecated-ports@<:@=yes/no@:>@], > 662: [Suppress the error when configuring for a deprecated port > @<:@no@:>@])]) > 663: if test "x$OPENJDK_TARGET_OS" = xmacosx && test "x$OPENJDK_TARGET_CPU" > = xx86_64; then Do we need to exclude zero here the way we did for 32-bit x86? ------------- PR Review: https://git.openjdk.org/jdk/pull/31684#pullrequestreview-4588544266 PR Review Comment: https://git.openjdk.org/jdk/pull/31684#discussion_r3488979576
