On Mon, 29 Jun 2026 02:11:17 GMT, David Holmes <[email protected]> wrote:

>> Implementation of the JEP to deprecate the macOS/x64 port for removal. Note 
>> that the JEP is still in Submitted state. Meanwhile, I'm opening this PR for 
>> awareness and for your help reviewing the proposed changes.
>> 
>> In particular, I could use your help making sure the change to GHA 
>> (`main.yml`) does the right thing. The intention is to allow running 
>> macOS/x64 builds/tests, but to not include the port by default.
>> 
>> ---------
>> - [X] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> make/autoconf/platform.m4 line 663:
> 
>> 661:   AC_ARG_ENABLE(deprecated-ports, 
>> [AS_HELP_STRING([--enable-deprecated-ports@<:@=yes/no@:>@],
>> 662:       [Suppress the error when configuring for a deprecated port 
>> @<:@no@:>@])])
>> 663:   if test "x$OPENJDK_TARGET_OS" = xmacosx && test 
>> "x$OPENJDK_TARGET_CPU" = xx86_64; then
> 
> Do we need to exclude zero here the way we did for 32-bit x86?

Probably.

That said, I am not sure MacOS/x86/Zero even builds. Zero relies hard on 
Linux/POSIX. Maybe there is enough of BSD glue to make it build. @vidmik, try 
`--with-jvm-variants=zero` on MacOS x86, does it even work?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/31684#discussion_r3490476662

Reply via email to