On Tue, 30 Jun 2026 13:21:22 GMT, Andrew Dinn <[email protected]> wrote:

>> David Simms has updated the pull request with a new target base due to a 
>> merge or a rebase. The pull request now contains 2859 commits:
>> 
>>  - Merge branch '8317277' into jep401_sub_review_8317278
>>  - Merge remote-tracking branch 'valhalla/lworld' into 8317277
>>  - Merge
>>    
>>    Merge jdk-28+4
>>  - 8386963: [lworld] Improve the exception message from Object 
>> synchronization methods on value objects
>>    
>>    Reviewed-by: dholmes, alanb
>>  - 8387300: [lworld] Minor review comments in javac
>>    
>>    Reviewed-by: vromero
>>  - 8387192: [lworld] Review comment drop for core libs
>>    
>>    Reviewed-by: jvernee, vromero
>>  - 8386999: [lworld] C2: assert(is_dead_loop_safe()) failed: shouldn't be 
>> cleared yet
>>    
>>    Reviewed-by: qamai, vlivanov
>>  - 8386787: [lworld] 
>> compiler/valhalla/inlinetypes/TestValueConstruction.java#StressIncrementalInliningDontInlineMyAbstractInit
>>  timed out
>>    
>>    Reviewed-by: phubner, chagedorn
>>  - 8386995: [lworld] Duplicate value classes are a preview feature warning
>>    
>>    Reviewed-by: alanb, vromero
>>  - 8383389: [lworld] Augment AOTMapLogger::print_oop_details to support flat 
>> arrays with oops
>>    
>>    Reviewed-by: iklam, fparain
>>  - ... and 2849 more: https://git.openjdk.org/jdk/compare/193de1b1...cffcfb57
>
> src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp line 13670:
> 
>> 13668:     __ mov(c_rarg0, rthread);
>> 13669: 
>> 13670:     __ mov(rscratch1, destination);
> 
> This target needs to be marked as an external address so we can relocate it 
> when we save and restore the code blob:
> 
> Suggestion:
> 
>     __ mov(rscratch1, ExternalAddress(destination));

Will be fixed by [JDK-8387661](https://bugs.openjdk.org/browse/JDK-8387661).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/31122#discussion_r3512764045

Reply via email to