On Tue, 14 Jul 2026 17:42:26 GMT, Aleksey Shipilev <[email protected]> wrote:

>> Andrew Haley has updated the pull request incrementally with two additional 
>> commits since the last revision:
>> 
>>  - Merge branch 'JDK-8134940' of https://github.com/theRealAph/jdk into 
>> JDK-8134940
>>  - Simplify overflow handling
>
> src/hotspot/cpu/x86/c1_LIRAssembler_x86.cpp line 1484:
> 
>> 1482:       type_profile_helper(mdo, md, data, recv, Rtmp1);
>> 1483:     } else {
>> 1484:       __ testptr(value, value);
> 
> Seems to have already did the same thing at L1467.

Well, yes, but `type_profile_helper` just clobbered our flags. That's x86 for 
you.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28541#discussion_r3594203873

Reply via email to