On Tue, 14 Jul 2026 14:43:14 GMT, Andrew Dinn <[email protected]> wrote:
>> Andrew Haley has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Merge branch 'JDK-8134940' of https://github.com/theRealAph/jdk into >> JDK-8134940 >> - Simplify overflow handling > > src/hotspot/cpu/x86/c1_MacroAssembler_x86.cpp line 278: > >> 276: // In effect, the CRC instruction is being used here for its >> 277: // linear feedback shift register. >> 278: movl(temp, 0); > > On aarch64 we have asserts to detect a zero state when using crc32. Why do we > not also need them here on x86? > Likewise in the save and restore routines? Laziness, I guess. I wanted to make sure that we weren't missing any saves/restores that might lead to a zero state, and I found a few. x86 follows the same structure as AArch64. I guess it would be quicker simply to make x86 have the same assertions as AArch64 than debate it, so... ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/28541#discussion_r3594194304
