On Tue, 11 Aug 2026 08:30:13 GMT, Claes Redestad <[email protected]> wrote:
> This PR splits the JDK build of microbenchmarks into two passes, one which > builds with `--enable-preview` and the other without. As the micros which > currently needs to be built with preview are contained in only two packages > I've opted for the minimalist solution of listing those in the makefile. A > future enhancement might be to add some annotation-driven discriminator but > this seems like overkill to me. > > Also drive-by adjusted an error in the documentation of SetupJavaCompilation > (package names to INCLUDES / EXCLUDES should be provided with slashes, not > dots) and removed `--enable-preview` from a couple of microbenchmarks which > no longer need it. > > One glaring limitation of a split-build approach is that code in each group > can no longer overlap or share code. As microbenchmarks are typically > self-contained this currently isn't and shouldn't become much of an issue. > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). LGTM. Just one minor nit. make/test/BuildMicrobenchmark.gmk line 83: > 81: org/openjdk/bench/java/lang/stable > 82: > 83: Nit: extra blank line ------------- Marked as reviewed by jnorlinder (Committer). PR Review: https://git.openjdk.org/jdk/pull/32296#pullrequestreview-4904586886 PR Review Comment: https://git.openjdk.org/jdk/pull/32296#discussion_r3756602736
