> This PR splits the JDK build of microbenchmarks into two passes, one which 
> builds with `--enable-preview` and the other without. As the micros which 
> currently needs to be built with preview are contained in only two packages 
> I've opted for the minimalist solution of listing those in the makefile. A 
> future enhancement might be to add some annotation-driven discriminator but 
> this seems like overkill to me. 
> 
> Also drive-by adjusted an error in the documentation of SetupJavaCompilation 
> (package names to INCLUDES / EXCLUDES should be provided with slashes, not 
> dots) and removed `--enable-preview` from a couple of microbenchmarks which 
> no longer need it. 
> 
> One glaring limitation of a split-build approach is that code in each group 
> can no longer overlap or share code. As microbenchmarks are typically 
> self-contained this currently isn't and shouldn't become much of an issue. 
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

Claes Redestad has updated the pull request incrementally with one additional 
commit since the last revision:

  De-duplicate and add missing dependency

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/32296/files
  - new: https://git.openjdk.org/jdk/pull/32296/files/66330448..bb304368

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=32296&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=32296&range=01-02

  Stats: 96 lines in 1 file changed: 42 ins; 47 del; 7 mod
  Patch: https://git.openjdk.org/jdk/pull/32296.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/32296/head:pull/32296

PR: https://git.openjdk.org/jdk/pull/32296

Reply via email to