On Tue, 11 Aug 2026 08:30:13 GMT, Claes Redestad <[email protected]> wrote:

> This PR splits the JDK build of microbenchmarks into two passes, one which 
> builds with `--enable-preview` and the other without. As the micros which 
> currently needs to be built with preview are contained in only two packages 
> I've opted for the minimalist solution of listing those in the makefile. A 
> future enhancement might be to add some annotation-driven discriminator but 
> this seems like overkill to me. 
> 
> Also drive-by adjusted an error in the documentation of SetupJavaCompilation 
> (package names to INCLUDES / EXCLUDES should be provided with slashes, not 
> dots) and removed `--enable-preview` from a couple of microbenchmarks which 
> no longer need it. 
> 
> One glaring limitation of a split-build approach is that code in each group 
> can no longer overlap or share code. As microbenchmarks are typically 
> self-contained this currently isn't and shouldn't become much of an issue. 
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

This pull request has now been integrated.

Changeset: 86d80bd3
Author:    Claes Redestad <[email protected]>
URL:       
https://git.openjdk.org/jdk/commit/86d80bd392c9b1b801394d657a8c7fdf095761e1
Stats:     95 lines in 4 files changed: 57 ins; 27 del; 11 mod

8390113: JEP 401 integration breaks some pre-existing microbenchmarks

Reviewed-by: erikj, liach, jnorlinder

-------------

PR: https://git.openjdk.org/jdk/pull/32296

Reply via email to