On Mon, 7 Sep 2026 07:08:12 GMT, Jaikiran Pai <[email protected]> wrote:

> Can I please get a review of this change which addresses the issue noted in 
> https://bugs.openjdk.org/browse/JDK-8391869?
> 
> The change now reduces the chances of the jtreg failure handler in the JDK 
> identifying an incorrect file as a core dump file. In theory, this check can 
> be made much more stricter but I didn't want add that complexity.
> 
> I've verified that with this change `.mdmp` and `core.<xxx>` files continue 
> to be considered as a core dump files and yet any JAR files that may have had 
> "core" in their file names are no longer considered as core dump files.
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

Hello David, I had looked at the history of this code and hadn't spotted 
anything specific that would have necessitated the current implementation. It 
was brought in as part of a bigger change through 
https://github.com/openjdk/jdk/commit/8c8422e0f8886d9bbfca29fd228368f88bf46f2c#diff-60dd65b5ac575a237119402b91be118bc71754f1e7a739b323ac788112646c9eR88-R92
 for https://bugs.openjdk.org/browse/JDK-8267893.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/32723#issuecomment-5567861126

Reply via email to