On Mon, 7 Sep 2026 07:08:12 GMT, Jaikiran Pai <[email protected]> wrote:

> Can I please get a review of this change which addresses the issue noted in 
> https://bugs.openjdk.org/browse/JDK-8391869?
> 
> The change now reduces the chances of the jtreg failure handler in the JDK 
> identifying an incorrect file as a core dump file. In theory, this check can 
> be made much more stricter but I didn't want add that complexity.
> 
> I've verified that with this change `.mdmp` and `core.<xxx>` files continue 
> to be considered as a core dump files and yet any JAR files that may have had 
> "core" in their file names are no longer considered as core dump files.
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

The naming pattern of core files is at least on Linux very configurable. In the 
past, the default for our test hosts was just `core`, which was tricky to deal 
with. We now standardize on `core.<pid>` IIRC. Maybe `.startsWith("core")` is a 
more reasonable conservative change?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/32723#issuecomment-5649048118

Reply via email to