On Wed, 16 Sep 2026 01:16:11 GMT, John R Rose <[email protected]> wrote:
>> Vladimir Kozlov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> More cleanups and fixes. Includes RISC-V suggested changes. > > src/hotspot/share/code/aotCodeCache.hpp line 222: > >> 220: >> 221: address* _extrs_addr; >> 222: address* _stubs_addr; > > Speaking of UB, `init_extrs` allocates `_stubs_addr` but does not initialize > it. It’s probably a wonderful fact that nobody will ever touch the toxic > bits of that array, unless they really know somebody else already planted a > defined address in it. Still, it feels like jazz dancing at the top of a > cliff over a snakepit. Can we please zero out `_stubs_addr` on allocation? Done. I also cleared _extrs_addr array on allocation. Not all slots are filled. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30778#discussion_r4021703529
