On Wed, 16 Sep 2026 23:44:02 GMT, Leonid Mesnik <[email protected]> wrote:

>> Vladimir Kozlov has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Check result for NULL in address_for_id()
>
> test/hotspot/jtreg/runtime/cds/appcds/aotCode/AOTCodeTestUnknownExternAddress.java
>  line 40:
> 
>> 38:  * @run driver jdk.test.lib.helpers.ClassFileInstaller -jar app.jar
>> 39:  *                 TestUnknownAddress
>> 40:  * @run driver/timeout=1500 ${test.main.class}
> 
> is timeout 1500 is needed for this test

Same here. In tier1 it took max 17 sec on linux-aarch64. I will remove these 
timeout after testing.

> test/hotspot/jtreg/runtime/cds/appcds/aotCode/TestAOTCodeCounters.java line 
> 39:
> 
>> 37:  *                 JavacBenchApp$FileManager
>> 38:  *                 JavacBenchApp$SourceFile
>> 39:  * @run driver/timeout=1500 ${test.main.class}
> 
> Seems that these new tests in the aotCode are executed in tier1. I think that 
> they are too expensive for tier1 and should be excluded or moved in directory
> runtime/cds/appcds/applications
> which is not a part of tier1.

It could copy/past error.  It took 80 sec on linux-aarch64.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/30778#discussion_r4032571947
PR Review Comment: https://git.openjdk.org/jdk/pull/30778#discussion_r4032570431

Reply via email to