Andy, On Wed, Jun 13, 2007 at 12:02:28PM +0200, Steve M. wrote:
>I tried the Patches and got some compiler warnings while building. >Functionality seems ok after a quick tryout. > > > CC archival/rpm.o >archival/rpm.c:268: warning: no previous prototype for >?rpm_construct_scan_state? has to be static. >archival/rpm.c:272: warning: no previous prototype for >?rpm_destruct_scan_state? has to be static. >archival/rpm.c: In function ?DoInstallEraseUpdateSeqences?: >archival/rpm.c:679: warning: declaration of ?sz? shadows a previous local >archival/rpm.c:552: warning: shadowed declaration is here Without having looked at the code, you should reuse this variable, not re-declare it. >archival/rpm.c: In function ?DoQueryListFiles?: >archival/rpm.c:1080: warning: declaration of ?pszRoot? shadows a global >declaration >archival/rpm.c:79: warning: shadowed declaration is here >archival/rpm.c: At top level: >archival/rpm.c:1179: warning: no previous prototype for ?rpm_main? >archival/rpm.c: In function ?rpm_main?: missing prototype. See e.g. coreutils/true.c >archival/rpm.c:1192: warning: ISO C90 forbids mixed declarations and code put your decls to the beginning of the function. >archival/rpm.c:1609: warning: passing argument 3 of ?DoQueryListFiles? >discards qualifiers from pointer target type type mismatch >archival/rpm.c: In function ?extract_cpio_gz?: >archival/rpm.c:1747: warning: passing argument 2 of >?rpm_open_transformer? from incompatible pointer type >archival/rpm.c: At top level: >archival/rpm.c:300: warning: ?exec_script? declared ?static? but never >defined >archival/rpm.c:1999: warning: ?fileaction_list? defined but not used >archival/rpm.c:520: warning: ?PrintDependency? defined but not used Either you do not need these or you have to wrap them in the corresponding #if ENABLE_FEATURE_RPM_FOO > > CC coreutils/md5_sha1_sum.o >coreutils/md5_sha1_sum.c:28: warning: no previous prototype for ?hash_file? Needs a prototype in libbb and should be moved to libbb, consequently. _______________________________________________ busybox mailing list [email protected] http://busybox.net/cgi-bin/mailman/listinfo/busybox
