Greetings, I have compiled Andy Green's RPM improvements for BusyBox 1.7.0 using both SnapGear as well BuildRoot toolchains.
Functionally, it performs most of the tasks I need. I think an "improvement" is not a correct word for Andy's changes. Without them rpm as it comes with BusyBox is pretty much useless. With his changes rpm provides at least basic functionality needed to effectively use RPMs. I hope Andy's changes will be incorporated in the current release. -----Original Message----- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Steve M. Sent: Tuesday, June 12, 2007 3:52 PM To: Andy Green Cc: [email protected] Subject: Re: [PATCH Try#2 3/3] Major improvements to RPM Hi folks, I built a version from current svn with that patch (the #3) and it worked ok in a short test. During compilation I got these warnings: archival/rpm.c:79: warning: initialization discards qualifiers from pointer target type archival/rpm.c:268: warning: no previous prototype for 'rpm_construct_scan_state' archival/rpm.c:272: warning: no previous prototype for 'rpm_destruct_scan_state' archival/rpm.c: In function 'DoInstallEraseUpdateSeqences': archival/rpm.c:679: warning: declaration of 'sz' shadows a previous local archival/rpm.c:552: warning: shadowed declaration is here archival/rpm.c: In function 'DoQueryListFiles': archival/rpm.c:1080: warning: declaration of 'pszRoot' shadows a global declaration archival/rpm.c:79: warning: shadowed declaration is here archival/rpm.c: At top level: archival/rpm.c:1179: warning: no previous prototype for 'rpm_main' archival/rpm.c: In function 'rpm_main': archival/rpm.c:1192: warning: ISO C90 forbids mixed declarations and code archival/rpm.c: In function 'extract_cpio_gz': archival/rpm.c:1747: warning: passing argument 2 of 'rpm_open_transformer' from incompatible pointer type archival/rpm.c: At top level: archival/rpm.c:300: warning: 'exec_script' declared 'static' but never defined archival/rpm.c:1999: warning: 'fileaction_list' defined but not used archival/rpm.c:520: warning: 'PrintDependency' defined but not used I also have a general question about that. At line 79 the following is declared: static char *pszRoot, *szEmpty = ""; szEmpty is only used once for if(defaultPath) pszRoot = szEmpty; else pszRoot = specifiedPath; Is there a benefit from using szEmpty instead of simply doing pszRoot = ""; ? Greetings, Steve M. _______________________________________________ busybox mailing list [email protected] http://busybox.net/cgi-bin/mailman/listinfo/busybox ---------------------------------------------------------------------- This e-mail, including any attached files, may contain confidential and privileged information for the sole use of the intended recipient. Any review, use, distribution, or disclosure by others is strictly prohibited. If you are not the intended recipient (or authorized to receive information for the intended recipient), please contact the sender by reply e-mail and delete all copies of this message. _______________________________________________ busybox mailing list [email protected] http://busybox.net/cgi-bin/mailman/listinfo/busybox
