On Fri, 2 Aug 2019 22:40:01 +0800 Kang-Che Sung <explore...@gmail.com> wrote:
> What I suggested is to remove these lines:
>
> if (st.st_dev == rootdev) {
> // Show usage, it says new root must be a mountpoint
> bb_show_usage();
> }
>
> Because mount(..., MS_MOVE) will do the same check before moving the mount
> point, and the check would be done before deleting anything if your patch
> is applied. (And there is no point to show the program usage when it's
> already PID 1. You would rather see error message of what specifically goes
> wrong. The kernel will panic when PID 1 dies, leaving you no option but
> reboot.)
Thank you for your suggestion.
patch
Description: Binary data
_______________________________________________ busybox mailing list busybox@busybox.net http://lists.busybox.net/mailman/listinfo/busybox
