I split out the third patch for this reason. I agree, it can be dropped if people see no need for it. Adding a compile-time option I think is overkill.
Daniel On 03/09/2019 04.31, Kang-Che Sung wrote: >> From 12d30559486502feec4e2821b3ab45ae6139e7aa Mon Sep 17 00:00:00 2001 >> From: Daniel Edgecumbe <g...@esotericnonsense.com> >> Date: Mon, 2 Sep 2019 22:09:15 +0100 >> Subject: [PATCH 3/3] gzip: set default compression level to 6 when >> CONFIG_FEATURE_GZIP_LEVELS=n >> >> With this change, GNU gzip -n and BusyBox gzip now produce identical output >> assuming that CONFIG_GZIP_FAST=2. >> --- > > Excuse me, but I wonder one thing on the third patch: Why should we follow > strictly with gzip on the no-options default behavior? gzip -9 is quite fast > in modern processors, and if someone builds busybox without > CONFIG_FEATURE_GZIP_LEVELS, I think they are moke likely to stick with -9 as > default instead of -6. > > The better change would be to allow the builder to choose the compression > level > at build time. It would be better to resolve the debate on which level should > be the default, Otherwise, I think the third patch can be dropped. > -- Daniel Edgecumbe | esotericnonsense Kalix NO, Sverige | +358 46 584 2810 em...@esotericnonsense.com | https://esotericnonsense.com _______________________________________________ busybox mailing list busybox@busybox.net http://lists.busybox.net/mailman/listinfo/busybox
