Hello Denys,
On Mon, Feb 26, 2024 at 2:13 PM Denys Vlasenko <vda.li...@googlemail.com> wrote:
>
> On Sun, Feb 25, 2024 at 10:13 AM Dario Binacchi
> <dario.binac...@amarulasolutions.com> wrote:
> > I developed this application to test the Linux kernel series [1]. As
> > described in it I could not use the iproute2 package since the
> > microcontroller is without MMU.
>
> I don't think we need to have "iplinkcan" applet.
> (I'm not sure having the non-standard "iplink" et al was a good idea
> in the first place)
> Let's just use "ip link set type can ..." syntax only
>
>
>
> > + case ARG_restart: {
> > + __u32 val = 1;
> > +
> > + NEXT_ARG();
> > + addattr_l(&req.n, sizeof(req), IFLA_CAN_RESTART,
> > &val, sizeof(val));
> > + break;
> > + }
>
> Why NEXT_ARG()? "restart" has no parameters, right?
You are right.
Do I need to make a patch to remove the comment? Or does it not matter?
I reran the tests for my use cases. Everything is okay.
Thanks for the review and having merged the patch
Thanks and regards,
Dario
>
> I'm applying your patch with some changes.
> Please try current git.
--
Dario Binacchi
Senior Embedded Linux Developer
dario.binac...@amarulasolutions.com
__________________________________
Amarula Solutions SRL
Via Le Canevare 30, 31100 Treviso, Veneto, IT
T. +39 042 243 5310
i...@amarulasolutions.com
www.amarulasolutions.com
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
