Hi,
On 2025. 03. 07. 10:18, Nop wrote:
Okay, I checked the ISO 9899 standard and yes, you're, it is defined
that if the main reach the } and should return a compatible type, then
it returns 0.
Don't know why it was only an extension in my mind. I was aware that it
is the case in C++, but was not sure for the C.
Anyway, I still consider omitting as a bad practice. You only avoid
typing few chars and create doubt in the mind of non-experts.
Instead, adding it is explicit and does not create any doubt to anyone.
Also, my others changes are still valid.
I agree that the "correct" solution is to include the return, to avoid
having to fix it again in some future GCC version. Plus, since that
patch is part of Buildroot since last July, and has been in two major
Buildroot versions (2024.08 and 2024.11), I'd say it's been battle-tested.
BTW Nop should have included a link to his patch, to make it easier to
review, but anyways, here it is:
https://gitlab.com/buildroot.org/buildroot/-/blob/ed84e971c36b43f564df881d86ac459bb5b7dad0/package/busybox/0006-menuconfig-GCC-failing-saying-ncurses-is-not-found.patch
Bence
_______________________________________________
busybox mailing list
[email protected]
https://lists.busybox.net/mailman/listinfo/busybox
