Yeah this seems to do the trick. Again a question. Now that it is possible to see whether we try to click _not_ on a specific file, should there be an else statement with a OliveMenu without the selected=self.get_selected_right() or maybe a treeselection.select_path(None) to reflect that fact? And stylewise according to PEP8 'if treepathpos is not None' is better so changing that would be nice.

Also, I noticed that a right mouse button press event on the bookmarklist does 'The Right Thing'. I think this is (if you look at line 824, the on_treeview_left_button_press_event method) because self.get_selected_left is called twice. So I guess that is option number three to fix the behaviour. :)

But I like this one for being easy to extend with more elaborate if/else constructs later on.

bb:tweak

Jasper

Kevin Light wrote:
Here is a second pass at fixing the right click on file tree selection updates.
This round finds the click point and then selects the item under the click.
If this is considered a better solution, please reject the previous patch.


Attachment: signature.asc
Description: OpenPGP digital signature

-- 
bzr-gtk mailing list
[email protected]
Modify settings or unsubscribe at: 
https://lists.canonical.com/mailman/listinfo/bzr-gtk

Reply via email to