Awesome! :) bb:approve One tiny thingy remaining that has less to do with your changes:According to the pygtk tutorial (at http://www.pygtk.org/pygtk2tutorial/sec-Events.html) talking about button_press_event callback functions: The value returned from this function indicates whether the event should be propagated further by the GTK+ event handling mechanism. Returning True indicates that the event has been handled, and that it should not propagate further. Returning False continues the normal event handling. See Chapter 20, Advanced Event and Signal Handling for more details on this propagation process.
Since we now do the selection changing ourselves, is there a reason to keep propagating the event? I know, I know.. this is getting overzealous but looks like (there we go again) 'The Right Thing' :P I tried it by putting return True at the return positions of both button_press_event functions and at least nothing breaks for me. :)
Jasper Kevin Light wrote:
Here is a third patch that does all of the functionality correctly. This fixes the bookmark and file panes.
signature.asc
Description: OpenPGP digital signature
-- bzr-gtk mailing list [email protected] Modify settings or unsubscribe at: https://lists.canonical.com/mailman/listinfo/bzr-gtk
