Added franks suggested changes, and new webrev is online changes to
installation-screen.c.
Also just completed doing a VBox install of a DC ISO which contains these
changes and I can su to root using the users password, all looks good from
my side.
cheers
Matt
Frank Ludolph wrote:
> Matt Keenan wrote:
>> Sundar Yamunachari wrote:
>>> Matt Keenan wrote:
>>>> New change of passing in the user's password as roots password to
>>>> om_perform_install(), in installation-screen.c, has been done and new
>>>> webrev has been posted.
>>>>
>>>> All other source files are exactly the same as the previous webrev.
>>> The changes look okay. I have couple of questions
>>>
>>> 1. Did you verify that you could assume super-user role ("su") with
>>> the admin user password?
>>
>> I've yet to test the these specific code changes, I am going to
>> generate a
>> test ISO with these changes as part of my test cycle.
>>
>>> 2. Since we set the root password the same as the admin user
>>> password, do we need to tell the user in the summary panel that "the
>>> super user password is same as that of the administrative user?
>>
>> Very good point, the Help should definitely be changed to reflect this,
>> changes to the Summary panel are quite easy to do, would need to get
>> confirmation from Frank on what the exact wording should be,
>>
> Remove the "Root Account" line. Add "Root Password: Same as user
> account" below the User Account line.
> Updated UI spec and mockup.
> http://xdesign.sfbay.sun.com/projects/solaris/subprojects/install/design/screensSlim08-11.html
>
>
>
> Frank
>>
>>
>>>
>>> Thanks,
>>> Sundar
>>>>
>>>> cheers
>>>>
>>>> Matt
>>>>
>>>> sundar Yamunachari wrote:
>>>>> Matt,
>>>>> Based on the comments from Darren Moffett, we will use the same
>>>>> password for both the initial user and root. Please update your
>>>>> code review to incorporate this change.
>>>>>
>>>>> Thanks,
>>>>> Sundar
>>>>>
>>>>> Matt Keenan wrote:
>>>>>>
>>>>>> Thanks for the comments Sundar.
>>>>>>
>>>>>> I've logged bug :
>>>>>> http://defect.opensolaris.org/bz/show_bug.cgi?id=12204
>>>>>>
>>>>>> to get liborchestrator fixed, based on this can I assume the
>>>>>> changes here are ok
>>>>>> to push back ?
>>>>>>
>>>>>> cheers
>>>>>>
>>>>>> Matt
>>>>>>
>>>>>> Sundar Yamunachari wrote:
>>>>>>> Matt Keenan wrote:
>>>>>>>> On test install entry in /etc/shadow for root is :
>>>>>>>>
>>>>>>>> root::14537::::::
>>>>>>>>
>>>>>>>> Which indicates it is set to "", yet
>>>>>>>>
>>>>>>>> $ su -
>>>>>>>>
>>>>>>>> fails as it prompts for a password, and simply pressing return
>>>>>>>> fails to su.
>>>>>>>>
>>>>>>>> So I :
>>>>>>>> $ pfexec passwd root
>>>>>>>>
>>>>>>>> And hit return twice, which should be setting root password to
>>>>>>>> nothing.
>>>>>>>> Now "su -" works when I just hit return for password, also now
>>>>>>>> /etc/shadow
>>>>>>>> now contains a hashed password for root.
>>>>>>>>
>>>>>>>> Is this behaviour expected, and acceptable ?
>>>>>>> I think that it is a regression and the problem may be with the
>>>>>>> orchestrator. It sets the password to "" if it is not passed. We
>>>>>>> need to get it fixed.
>>>>>>>
>>>>>>> - Sundar
>>>>>>>>
>>>>>>>> cheers
>>>>>>>>
>>>>>>>> Matt
>>>>>>>>
>>>>>>>> Sundar Yamunachari wrote:
>>>>>>>>> Matt,
>>>>>>>>>
>>>>>>>>> The changes look ok. The install library liborchestrator
>>>>>>>>> expects root password and I think it sets the root password to
>>>>>>>>> "", if it is not passed from the GUI. What is the root password
>>>>>>>>> after your test installation with the fix?
>>>>>>>>>
>>>>>>>>> - Sundar
>>>>>>>>>
>>>>>>>>> Matt Keenan wrote:
>>>>>>>>>>
>>>>>>>>>> Are people ok with these changes going into the GUI ?
>>>>>>>>>> Anyone get a chance to review ?
>>>>>>>>>>
>>>>>>>>>> cheers
>>>>>>>>>>
>>>>>>>>>> Matt
>>>>>>>>>>
>>>>>>>>>> Matt Keenan wrote:
>>>>>>>>>>> Code review request for bug :
>>>>>>>>>>> 1436 - Installation does not need to ask Root Password
>>>>>>>>>>> http://defect.opensolaris.org/bz/show_bug.cgi?id=1436
>>>>>>>>>>>
>>>>>>>>>>> This fix also resolves bug :
>>>>>>>>>>> 64 - GDM dosen't accept empty passwords, but setup does.
>>>>>>>>>>> http://defect.opensolaris.org/bz/show_bug.cgi?id=64
>>>>>>>>>>>
>>>>>>>>>>> Webrev :
>>>>>>>>>>> http://cr.opensolaris.org/~mattman/bug_1436/
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> The users screen has been redesigned in that root password
>>>>>>>>>>> entry fields have now been removed as they are not required.
>>>>>>>>>>> However the change also makes log-in name
>>>>>>>>>>> and password mandatory, this will ensure that for every
>>>>>>>>>>> install a initial user
>>>>>>>>>>> will be created with a password.
>>>>>>>>>>>
>>>>>>>>>>> Testing :
>>>>>>>>>>> Created a install LiveCD ISO via Distro Constructor and did
>>>>>>>>>>> a test install
>>>>>>>>>>> within virtualbox.
>>>>>>>>>>>
>>>>>>>>>>> cheers
>>>>>>>>>>>
>>>>>>>>>>> Matt
>>>>>>>>>>> _______________________________________________
>>>>>>>>>>> caiman-discuss mailing list
>>>>>>>>>>> caiman-discuss at opensolaris.org
>>>>>>>>>>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
>>>>>>>>>>
>>>>>>>>>> _______________________________________________
>>>>>>>>>> caiman-discuss mailing list
>>>>>>>>>> caiman-discuss at opensolaris.org
>>>>>>>>>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
>>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>
>
