Susan Sohn wrote: > Right, of course. > > Sue > > On 11/16/09 10:35, jeanm wrote: >> Susan Sohn wrote: >>> setup-sparc.sh: >>> I'm not seeing a difference between line 114 and line 115? >> Correct. Each one moves you up one directory.
Ah yes. This raised an eyebrow for me too. Maybe it would be clearer to future readers to comment it or use a different variable name for the first call. My suggestions: tmp_dir_one_level_up=`/usr/bin/dirname "$image_directory"` image_directory=`/usr/bin/dirname "$image_directory"` Or # # Invoking dirname twice to move up two directory levels. # ... What do you think? Joe >> >> Jean >>> >>> Sue >>> >>> On 11/16/09 09:54, jeanm wrote: >>>> Could I get a code review (Alok and Jan preferred) for the following: >>>> >>>> 12612 <http://defect.opensolaris.org/bz/show_bug.cgi?id=12612> >>>> get_service_with_global_scope() looks in the wrong place for the >>>> boot archive >>>> 12642 <http://defect.opensolaris.org/bz/show_bug.cgi?id=12642> >>>> platform directory needs to only contain the necessary files >>>> >>>> >>>> >>>> >>>> webrev: >>>> >>>> http://cr.opensolaris.org/~jeanm/slim_12612_12642/ >>>> >>>> If you are planning to look at this please let me know so I don't >>>> push before you get back to me. >>>> >>>> >>>> Thanks, >>>> >>>> jean >>>> _______________________________________________ >>>> caiman-discuss mailing list >>>> caiman-discuss at opensolaris.org >>>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >>> >> > > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
