Thanks for the review Jan. comments inline.
Jean Jan Damborsky wrote: > Hi Jean, > > > ai_post_boot_archive_pkg_image_mod > ---------------------------------- > > lines 90-91: > > According to PSARC/2006/525, Sparc kernel is obtained directly from > boot archive > (please see section 6.2 and 6.3 in following document): > > http://arc.opensolaris.org/caselog/PSARC/2006/525/final.materials/spec > > Based on this, I believe that we can safely get rid of 'unix' binaries > in Sparc case: > > 90 $FIND . -type f -a ! -name unix -a ! -name wanboot -a ! -name > boot_archive | $XARGS \ > 91 $RM -f > -> > 90 $FIND . -type f -a ! -name wanboot -a ! -name boot_archive | > $XARGS $RM -f > > I have tried and it works for AI and for installed system (removed all > 'unix' binaries > not residing in boot_archive), I believe it should work in the same > way for Bootable > media. > Done. Changing the comment above it accordingly too. > > setup-sparc.sh > -------------- > > 112 /usr/bin/grep "/boot/platform/sun4v/boot_archive" > ${WANBOOT_CONF_SPEC} > -> > 112 /usr/bin/grep "/boot/platform/sun4v/boot_archive" > ${WANBOOT_CONF_SPEC} > /dev/null > > I think we don't want to have that line displayed on console > if it exists. OK. Done. Jean > > Thank you, > Jan > > > > jeanm wrote: >> Could I get a code review (Alok and Jan preferred) for the following: >> >> 12612 <http://defect.opensolaris.org/bz/show_bug.cgi?id=12612> >> get_service_with_global_scope() looks in the wrong place for the boot >> archive >> 12642 <http://defect.opensolaris.org/bz/show_bug.cgi?id=12642> >> platform directory needs to only contain the necessary files >> >> >> >> >> webrev: >> >> http://cr.opensolaris.org/~jeanm/slim_12612_12642/ >> >> If you are planning to look at this please let me know so I don't >> push before you get back to me. >> >> >> Thanks, >> >> jean >> _______________________________________________ >> caiman-discuss mailing list >> caiman-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >
