Glenn Lagasse wrote: > * Karen Tung (Karen.Tung at Sun.COM) wrote: >> Hi Glenn, >> >> These messages are generated from the exec_cmd_outputs_to_log() function >> in usr/src/lib/install_utils/install_utils.py. Looking from the >> change history >> of this file, the following putback is the one that made the change: >> >> changeset: 635:74823d433dc4 >> user: Jan Damborsky <jan.damborsky at sun.com> >> date: Mon Nov 09 14:19:53 2009 +0100 >> summary: 6651 autoinstall needs more useful error messages from >> Orchestrator >> module >> >> All commands invoked by DC uses the exec_cmd_outputs_to_log() function. > > Ah-ha. That helps. So looks like changeset 635 was a tad aggressive > :-) > > I'll follow up with Jan. Thanks Karen!
Hi Karen, Glenn, confirming that changeset 635 is the culprit :-) No doubt that 'pkg' prefix in DC log is confusing and has to be removed. WRT having the command logged, I would like to check if it is in general something which could be acceptable in DC log. I am asking, since it is useful source of information in installer case and if something fails, there is an easy way to exactly reproduce the set of steps which led to the failure. Thinking about solution, we could [1] Repair the prefix [2] Avoid logging the command in DC case [3] Remove logging the command completely from exec_cmd_outputs_to_log() Please let me know what you think. Thank you, Jan
