Hi Glenn, Glenn Lagasse wrote: > Hi Jan, > > * Jan Damborsky (Jan.Damborsky at Sun.COM) wrote: > >> Hi Karen, Glenn, >> >> confirming that changeset 635 is the culprit :-) >> >> No doubt that 'pkg' prefix in DC log is confusing and has to be removed. >> WRT having the command logged, I would like to check if it is in general >> something which could be acceptable in DC log. >> I am asking, since it is useful source of information in installer case >> and if something fails, there is an easy way to exactly reproduce the set >> of steps which led to the failure. >> >> Thinking about solution, we could >> >> [1] Repair the prefix >> [2] Avoid logging the command in DC case >> [3] Remove logging the command completely from exec_cmd_outputs_to_log() >> >> Please let me know what you think. > > I like option 1 but I think we could go further. Some of the log > messages that are now showing up in the DC detailed log don't seem to be > terribly useful imho. Specifically the messages that list what > finalizer script is being called and what arguments it was passed. > These messages really clutter up the detailed log and makes reading it > pretty difficult. Is it possible to suppress these types of messages > unless specifically asked for (via some mechanism)?
I think that if particular messages are not useful, then there is no reason to have them logged at all. However, unless it can't be determined implicitly which messages should be logged, we would need to enhance the callers, so that they can decide which of those messages are reasonable to have captured in log file. To be honest, at this point I am not quite convinced if it is worth the effort. Jan
