Alexander Eremin wrote:
> On Fri, 2009-11-20 at 14:57 +0100, Jan Damborsky wrote:
> Default for newfs is 2048, so I think here is better:
> 158         if (nvlist_lookup_uint32(attrs,
> TI_ATTR_DC_RAMDISK_INODES_NUM,
>> 159             &ramdisk_nbpi) != 0) {
>> 160                 ls_write_dbg_message(TIDC, LS_DBGLVL_INFO,
>> 161                     "Number of bytes per inode not provided, newfs(1M)"
>> 162                     " will use the default value\n");
>> 163                 ramdisk_nbpi = 2048;
>> 164         }


I would like to avoid duplicating that logic in TI - the reason is
maintainability. If that logic ever changes in newfs(1M),
we would need to reflect that in TI as well.

Jan


Reply via email to