Evan Layton wrote: > Sarah Jelinek wrote: >> >> >> Moriah Waterland wrote: >>> Evan, >>> >>> I'd appreciate a code review for the fix: >>> >>> Bug 12224 libbe should use bootadm to set the default and not manually >>> manipulate the default entry in menu.lst >>> http://defect.opensolaris.org/bz/show_bug.cgi?id=12224 >>> >>> My webrev is at: >>> http://cr.opensolaris.org/~mwaterl/f12224 >>> >>> I have completed unit tests. I verified that beadm correctly updates >>> the default entry for menu.lst. I also ran the TET libbe test suite >>> against them and verified that my changes did not introduce any new >>> failures. >> >> Hi Moriah, >> >> Do we need to worry about the altroot in the case where we call this >> from the installer? Assuming we do call this function from the installer? >> > > This should not be getting called from the installer. Plus the altroot > isn't something that would ever make any difference for /rpool/boot/grub > since that path location is shared by all BE's.
ok, thanks. looks ok. sarah **** > > -evan > > >> thanks, >> sarah >> *** >>> >>> thanks, >>> >>> ---- >>> Moriah Waterland >>> Software Engineer >>> Solaris Core OS >>> Sun Microsystems >>> 303-272-7448 >>> >>> _______________________________________________ >>> caiman-discuss mailing list >>> caiman-discuss at opensolaris.org >>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >
