Jan,
Thanks for the review. Comments inline.
Jean
Jan Damborsky wrote:
> Hi Jean,
>
> I have just couple of nits, no need for another round of code review.
>
> Thank you,
> Jan
>
>
> ai_post_boot_archive_pkg_image_mod
> ----------------------------------
> 75-78 - I know that you didn't touch this part, but could you please
> remove those lines as they are duplicated at 80-83 ? Thank you.
Yes. Done.
>
> 86 - line too long
done
>
> 96 - we are moving 'platform' directory while we are there
> (the dir is entered at line 89. Just to be sure, I might recommend
> to leave the dir first, e.g.
>
> 96 ${MV} ${PKG_IMG_PATH}/platform ${PKG_IMG_PATH}/boot
> ->
> 96 cd ..
> 97 ${MV} ${PKG_IMG_PATH}/platform ${PKG_IMG_PATH}/boot
>
Correct. How about cd ${PKG_IMG_PATH}
>
> 98 - just to be consistent with rest of the changes:
> 98 cd $PKG_IMG_PATH
> ->
> 98 cd ${PKG_IMG_PATH}
>
>
done.
Jean
>
> jeanm wrote:
>> jeanm wrote:
>>> Could I get a code review (Alok and Jan preferred) for the following:
>>>
>>> 12612 <http://defect.opensolaris.org/bz/show_bug.cgi?id=12612>
>>> get_service_with_global_scope() looks in the wrong place for the
>>> boot archive
>>> 12642 <http://defect.opensolaris.org/bz/show_bug.cgi?id=12642>
>>> platform directory needs to only contain the necessary files
>>>
>>>
>> I've updated the webrev for the above fixes with the comments I
>> received. I've also add the following bug fix to the batch.
>> So please review that (delete_service.py). I ran the installadm
>> automated test suites to test it.
>>
>> CR: 12751 delete-service: fails to clean up vfstab
>>
>> Webrev: http://cr.opensolaris.org/~jeanm/slim_ai_bugs/
>>
>>
>> Jean
>>
>>>
>>>
>>> webrev:
>>>
>>> http://cr.opensolaris.org/~jeanm/slim_12612_12642/
>>>
>>> If you are planning to look at this please let me know so I don't
>>> push before you get back to me.
>>>
>>>
>>> Thanks,
>>>
>>> jean
>>> _______________________________________________
>>> caiman-discuss mailing list
>>> caiman-discuss at opensolaris.org
>>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
>>
>> _______________________________________________
>> caiman-discuss mailing list
>> caiman-discuss at opensolaris.org
>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
>
