Hi Keith, * Keith Mitchell (Keith.Mitchell at Sun.COM) wrote: > >Sarah, Sundar, Karen, Keith and Jack. > > > >All of you had provided us with feedback to the original webrev > >for the VMC project. Thank you again for that! > > > >As a reminder could each of you please confirm that the issues you > >had raised are acceptably addressed in the updated webrev? > > > >http://cr.opensolaris.org/~glagasse/webrev.diffs > > Hi Joe & Glenn, > > Sorry for not checking through this earlier! > > It seems like the code beneath im_pop.py's "if __name__ == > '__main__':" clause is not all properly indented.
Odd. Pylint didn't report any issues after I re-indented the file. Can you be more specific about what you believe isn't properly indented? > export_vm: 42: nit, typo: "prifix" -> "prefix" > > Everything else looks fine to me. Great. Thanks for re-reviewing this Keith. Cheers, -- Glenn
