Hi Joe, I have comment about 1 of your response in-line below. I removed everything else that I have no further comment on.
Joseph J. VLcek wrote: > > Hi Karen, > > Thank you for the feedback. My response are in-line below. > > Thank you! > > Joe > > Karen Tung wrote: >> Hi Glenn and Joe, >> >> Here are my comments on the updated webrev. >> >> usr/src/cmd/distro_const/vmc/create_vm: >> * lines 233-237: I think it is better to validate the value specified >> for disk_size immediately after you get the value in line 201. >> That way, we don't waste CPU power to get the other values if >> the disk_size is not valid. Same comment applies to the ram size, > > I feel a very minimal amount of CPU would be saved by combining the > parameter gathering with the parameter validation. I also fell doing > so would reduce the readability and therefor the maintainability. > > I would like to leave this as it is. I suppose it is up to you. Personally, wasting CPU power or not aside, I think the code is easier to read if all the validation for the same supplied argument happens in the same place instead of scattered all over. Thanks, --Karen
