Dave, My responses are below - all suggestions in ict.py and ls_main.c implemented.
Updated webrev: http://cr.opensolaris.org/~wmsch/bug-1040/ Original webrev: http://cr.opensolaris.org/~wmsch/bug-1040/orig/ Defect: http://defect.opensolaris.org/bz/show_bug.cgi?id=1040 Dave Miner wrote: > William Schumann wrote: >> [Due to various changes, this code review has been regenerated. >> Among the modifications are fixes, some new ICTs. >> - IPS Python module pkg.cfgfiles is now used for adding and modifying >> users. >> - The install-finish script now reads options from the command line. >> - 'beadm list -dH' is used to find the root dataset. >> William] >> >> Webrev: >> http://cr.opensolaris.org/~wmsch/bug-1040/ >> Defect: >> http://defect.opensolaris.org/bz/show_bug.cgi?id=1040 >> > > Meta-comment: do we need to adjust the progress percentages a bit based > on moving things out of transfer_mod.py? This seems like a good thing to do at the moment. To help with this, I've written a histogram to print out the delta times between ticks of the progress bar. But, I think that it should be addressed outside of ICT. ... > ict.py: > 577,623: no failsafe in OpenSolaris at this time, I'd just remove > > 841: dump already on a dataset, can remove > > 997: I fixed this as part of the changeset with bug 681 and friends, > pick it up from there Coded this earlier. Removed leftover TODO comments. > > 1368: check whether DC phase 0 has fixed this. > > ls_main.c, 486: A warning of an invalid debug level seems like it would > be nice. > install-finish: > 55: this can't happen, block can be deleted William
