Sanjay, I'll respond to the ict.py comments here. Updated webrev: http://cr.opensolaris.org/~wmsch/bug-1040/ Original webrev: http://cr.opensolaris.org/~wmsch/bug-1040/orig/ Defect: http://defect.opensolaris.org/bz/show_bug.cgi?id=1040
Sanjay Nadkarni wrote: ... > ict.py > 103 #import dumper ? removed > > 841: zvol can be a dump device > http://docs.sun.com/app/docs/doc/817-2271/6mhupg6nk?l=ru&a=view > Note that the block size should be set to 128k > (this impacts ti too..) Removed this per Dave Miner's comments. > > Should add_sysidtool_sys_unconfig_entries > be more flexible. i.e. I could forsee a need that other installers may > need to either or change the applications. Modified add_sysidtool_sys_unconfig_entries to take an optional parameter - a list of additional /etc/.sysidconfig.apps entries to append to the base list. > > should remove_install_specific_packages have the ability to accept a > list of pkgs. > This list may be different for different installers. For example, AI > may not have SUNWslim-utils. Replaced the hard-coded package with a parameter list of packages and modified install-finish to provide SUNWslim-utils > > 1334 cleanup_unneeded_files_and_directories. > I think it should be able to accept additional files. Added 2 optional parameters - list of additional files and list of directories to delete. > > failsafe related code can be removed. > > Removed William
