OK. Thanks Sundar!
Joe Sundar Yamunachari wrote: > Joseph J VLcek wrote: >> >> >> Issue 1: >> -------- >> >> usr/src/cmd/installadm/Makefile >> >> More of a "Please Confirm" than an issues... >> >> >> Maybe I'm just missing something and it's been a while since I've done >> a lot of Makefile work but I don't see why dependency $(SUBDIRS) is >> needed for target clean. >> >> Please confirm dependency $(SUBDIRS) is needed for target clean: . > It is always needed to clean the subdirectories. All actions like > install, all, clean should be propagated to all subdirectories. For > example, take a look at the usr/src/cmd/Makefile > > 53: all clean clobber install: $(SUBDIRS) $(PYTHONSUBDIRS) $(TOOLSSUBDIRS) >> >> Issue 2: >> ------- >> >> usr/src/pkgdefs/SUNWinstalladm-tools/prototype_com >> >> Again more of a "Please Confirm" than an issues... >> >> Is 755 correct for these files? >> >> And the first 2 are root "bin" and the last 1 is root sys... It stood >> out to me because of the inconsistency... >> >> >> Please confirm these are correct. >> >> >> 52 f none var/installadm/ai-webserver/ai-httpd.conf 755 root bin >> 53 f none var/installadm/ai-webserver/AI.db 755 root bin >> >> Is 755 root "sys" correct for these files? >> >> 56 f none var/installadm/ai-webserver/AI_data/default.xml 755 root sys > After your comments, I look at all definitions in the prototype, there > is no consistency (some are root sys and others are root bin). The same > for files. Even though ai-httpd.conf needs to have only read permission, > it has 755. There are other files in the same prototype. I filed bug > 5080 to track both permissions and ownership for all files in this > package. There is no point in fixing these two files along with this bug. > > Thanks, > Sundar > >> >> Hope this helps. >> Joe >> >> >> Sundar Yamunachari wrote: >>> Hi, >>> >>> Please review the following fixes to integrate AI documentation to >>> the SUNWInstalladm package. Most of the files are delivered by >>> documentation. Please review Makefile changes and prototype changes. >>> >>> The webrev is at: http://cr.opensolaris.org/~ysundar/4552 >>> >>> 4552 Add AI documentation to SUNWinstalladm-tools >>> http://defect.opensolaris.org/bz/show_bug.cgi?id=4552 >>> >>> 4905 SUNWinstalladm-tools needs a better NAME >>> http://defect.opensolaris.org/bz/show_bug.cgi?id=4905 >>> >>> >>> >>> Testing: >>> >>> 1. Build the package SUNWinstalladm-tools with the changes >>> 2. Test the package with the integration tool >>> kumbam% cd >>> /net/indiana-build.central//export/home/sundar/sundar_ai/nov14/slim_source/packages/i386/nightly-nd/ >>> >>> >>> kumbam% /net/paradise.sfbay/export/tools/bin/integrate -l install -r >>> nv_osol0811 -n SUNWinstalladm-tools >>> ############################################################################## >>> >>> >>> >>> (TEST MODE ONLY) Integrating Package 'SUNWinstalladm-tools' to >>> nv_osol0811 ... >>> >>> Sending item information to server for verification ... >>> >>> WARNING:Depend_PKG_MustExistInRelease:nv/SUNWinstalladm-tools(i386): >>> nv/missing_depend_pkg=SUNWpython-cherrypy # PKG must exist in release >>> >>> >>> >>> STATUS = PASSED (Test mode only, no item is integrated) >>> >>> ############################################################################## >>> >>> >>> >>> See http://spgweb.sfbay/SPE/SRE/Tools/re_audits.html for audit help. >>> >>> 3. Install the package on a test machine. The installation is >>> successful with out any errors. >>> 4. Accessed the documentation. Checked all links and there are no >>> errors. >>> >>> Thanks, >>> Sundar >>> >>> _______________________________________________ >>> caiman-discuss mailing list >>> caiman-discuss at opensolaris.org >>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >> >
