Sundar, Remove "specific" from line 38, otherwise fine. I don't need to see another webrev.
Thanks, Sue Sundar Yamunachari wrote: > Sue, > > I think putting the files in alphabetical order (as suggested by > Dave) makes more sense. So I have modified the webrev to incorporate the > change. Only prototype_com is changed. So the comments are removed and I > am not organizing based on the type of file. The webrev is in the same > place http://cr.opensolaris.org/~ysundar/4552 > > Thanks, > Sundar > > Susan Sohn wrote: >> Hi Sundar, >> >> Just a couple of teensy nits in the prototype_com file: >> >> o Any reason that the doc files are between the "specific files" and >> "server setup tools"? I would have like to see them at the end of the >> prototype file (or at the beginning). >> >> o line 93: >> Server->Installation Server >> (or even Automated Installation Server) >> >> Otherwise, looks good. >> Sue >> >> Sundar Yamunachari wrote: >>> Hi, >>> >>> Please review the following fixes to integrate AI documentation to >>> the SUNWInstalladm package. Most of the files are delivered by >>> documentation. Please review Makefile changes and prototype changes. >>> >>> The webrev is at: http://cr.opensolaris.org/~ysundar/4552 >>> >>> 4552 Add AI documentation to SUNWinstalladm-tools >>> http://defect.opensolaris.org/bz/show_bug.cgi?id=4552 >>> >>> 4905 SUNWinstalladm-tools needs a better NAME >>> http://defect.opensolaris.org/bz/show_bug.cgi?id=4905 >>> >>> >>> >>> Testing: >>> >>> 1. Build the package SUNWinstalladm-tools with the changes >>> 2. Test the package with the integration tool >>> kumbam% cd >>> /net/indiana-build.central//export/home/sundar/sundar_ai/nov14/slim_source/packages/i386/nightly-nd/ >>> >>> >>> kumbam% /net/paradise.sfbay/export/tools/bin/integrate -l install -r >>> nv_osol0811 -n SUNWinstalladm-tools >>> ############################################################################## >>> >>> >>> >>> (TEST MODE ONLY) Integrating Package 'SUNWinstalladm-tools' to >>> nv_osol0811 ... >>> >>> Sending item information to server for verification ... >>> >>> WARNING:Depend_PKG_MustExistInRelease:nv/SUNWinstalladm-tools(i386): >>> nv/missing_depend_pkg=SUNWpython-cherrypy # PKG must exist in release >>> >>> >>> >>> STATUS = PASSED (Test mode only, no item is integrated) >>> >>> ############################################################################## >>> >>> >>> >>> See http://spgweb.sfbay/SPE/SRE/Tools/re_audits.html for audit help. >>> >>> 3. Install the package on a test machine. The installation is >>> successful with out any errors. >>> 4. Accessed the documentation. Checked all links and there are no >>> errors. >>> >>> Thanks, >>> Sundar >>> >>> _______________________________________________ >>> caiman-discuss mailing list >>> caiman-discuss at opensolaris.org >>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >> >
