Sanjay Nadkarni wrote: > Jan Setje-Eilers wrote: >> Sanjay Nadkarni wrote: >>> >>> Please review this blocker for bug. >>> >>> http://cr.opensolaris.org/~nadkarni/bugfix5106/webrev/ >> >> Let's see, 1024^4/512 - 16^7*8 is 0, so that's the right number. >> However you're checking for <=. That's into the negative in the signed >> long. > ok. So the compare should be against unsigned long ? > >> >> Your convert_extvtoc_to_vtoc() mirrors extvtoctovtoc() with >> pointers, that looks fine. > Yup..except with a minor fix ;-) See the bug I filed against > extvtoctovtoc. Timestamps are not being copied.
BTW, in practice tiimestamps are "unsupported"/ununsed fields anyway. --shidokht > >> >> Thanks for putting this together. >> >> -jan >> >> >> >
