Hi Jean.
One more thing. In your reply to Karen this morning...
Jean McCormack wrote:
> Karen,
>
>
>
>> usr/src/cmd/distro_const/DC_checkpoint.py
>>
>> -lines 688-692: The checkpoint_name for each finalizer scripts is
>> required. You already
>> specified this requirement in the DC-manifest.rng. The manifest
>> checking module would
>> have already enforced that requirement, you don't need to check it here.
>>
> Not true. If you do this in the manifest file:
>
> <checkpoint name=""> Then it validates OK but the read code will return
> None.
>
>
I just checked, and the lowest level code (find_node() of the TreeAcc
module) never returns None. It will return an empty string if that's
what a found node contains. If there are no nodes found, it returns an
empty list.
The ManifestServ module calls find_node() and does not interpret the
values returned, so it doesn't return None either. Likewise
ManifestServ can receive an empty string and won't return None.
I noticed in your current code review, that dc_utils.py
get_manifest_value() line 54 now checks for a non-zero string length
before returning a string instead of None. That could be the cause of
what you're seeing.
Thanks,
Jack
