Here's my comments:
General: what if dc_log = logging.getLogger(DC_LOGGER_NAME) returns null
or generates an exception?
DC_checkpoint.py:
line 280: Shouldn't that be if (log_handler != None):
Question: Should all print statements now go to dc_log? Or
only select ones?
finalizer_checkpoint.py:
In other code you modified the shell_cmd calls to include logging. Do
you want to
do that here too?
finalizer_rollback.py:
ditto
line 66: that should be 9. One of the "length" is due to the program
itself, not an arg.
post_bootroot_pkg_image_mod:
Please add the usr zlib compression algorithm to the header comments
finalizer.py:
line 609: Should there be a space after signal and before " ?
transfer_mod.py: The assumption here is that you won't be logging via
the liblogsvc module
and via this logging module. Correct?
Jean
Karen Tung wrote:
> Hi,
>
> Please do a code review for changes to fix the following bugs:
>
> 3341 stop_on_error doesn't seem to work for finalizer scripts
> 3354 Logging of the DC app
> 3482 Return status from DC needs to reflect errors encountered
> 3417 /var fails pkg verify
> 3536 Change constructor to use lzma for non-usr archives on primary live CD
> 3460 Remove attrs and tags in <packages> section in manifest
>
> webrev:
>
> http://cr.opensolaris.org/~ktung/dc_logging/
>
> Thanks,
>
> --Karen
> _______________________________________________
> caiman-discuss mailing list
> caiman-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
>
