Evan, > > usr/src/lib/libbe/be_create.c: > > line 1306 - the goto isn't needed
removed. > line 1381 - We're not collecting any errors that may > have been returned > from be_get_snap and just returning a > generic BE_ERR_ZFS > be_errno. Can we collect any useful > information from errors > returned by this call? I changed it to BE_ERR_SS_EXISTS since this function really will only fail if there is a format error in the snapshot name. > We're not capturing any errors here and just > returning whatever > "ret" was set to previously, which in > this case appears to be 0. > ine 1519 - We should be collecting the error returned > from _be_mount > instead of returning the generic mount > error. > ine 1539 - same as 1519 but for unmount. These are being addressed in 3734 > line 1635 - Why not just "goto done" instead of the > ZFS_CLOSE and return? > unless the callback function has already > closed the zfs > handle. > shouldn't the callback function > be_destroy_zone_roots_callback > have already closed the zfs handle? Yes. I added another ZFS_CLOSE(zhp) to be_destroy_zone_roots_callback() so the handle is guaranteed to be closed upon return. > shouldn't this callback function always close the zfs > handle? > line 1719 - if the comparison fails we don't close > the zfs handle here. Right, changed as mentioned above in the previous comment.. Thanks Tim > line 2772 - We need a comment header for this > function. > > moving on to be_mount.c > > -evan > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-di > scuss -- This message posted from opensolaris.org
