Ethan Quach wrote: > > > Evan Layton wrote: >> Hi Joe, >> >> I've answered a few things below but I'll let Tim and Ethan hit the rest. >> > > answering the rest ... > >> Thanks again for your comments! >> >> -evan >> >> Joseph J VLcek wrote: >> >> > ...
>> > >> > Suggestion: use strncmp vs strcmp >> > 497 if (strcmp(active_str, "on") == 0) >> > > Is there any real benefit for strncmp in this case? Just to be safe... True not really needed. since "on" is coded there. > >> > usr/src/lib/libinstzones/instzones_api.h >> > (renamed usr/src/lib/libspmizones/spmizones_api.h) >> > >> +-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-= >> >> >> > >> > >> > 83 typedef struct _zoneBrandList zoneBrandList_t; >> > >> > struct _zoneBrandList is defined in spmizones_lib.h and referenced >> here >> > on line 83 but instzones_api.h does not include spmizones_lib.h >> > >> > This does not seem correct to me. Am I missing something? >> > > When using typedef to define a new object, the source object definition > doesn't have to be known. The typedef just creates an alias, and for our > case here, it is so that consumers of the api know nothing about the > internal > workings of the real object. Consumers then use accessor functions to > process their new object instance. > > Hope that answered your question. Sure. > > > thanks, > -ethan > Great Ethan and thanks for the explanations. Joe
