Tim Knitter wrote: > Ethan Quach wrote: > >> Tim, >> >> be_create.c >> --------------- >> 1385 - why is this changed to BE_ERR_SS_EXISTS ? >> a failure from be_get_snap() does not signify a snapshot exists. >> >> > > That should have been BE_ERR_SS_NOENT, signifying that the snapshot doesn't > exist since be_get_snap() failed to parse it. >
This failure here is when we're unable to parse out the snapshot name portion (the part after the @ ) from the origin dataset name returned by ZFS, presumably because the origin dataset name is malformed. So I think it either needs to be changed back to BE_ERR_ZFS, or perhaps BE_ERR_INVAL. Printing out the presumed unparsable origin dataset name in the debug line above it might be useful as well: - "get snapshot name from origin\n")); + "get snapshot name from origin %s\n), origin); thanks, -ethan > I'll change it. > > Tim > > >> -ethan >> >> >> >> >> Tim Knitter wrote: >> >>> Thanks to all for reviewing the snap2 webrev. >>> >>> Please review my changes based on the comments I addressed from Evan, Ethan >>> and Joe. >>> >>> http://cr.opensolaris.org/~tsk/codeReviewCommentsSnap2/ >>> >>> Thanks >>> Tim >>> _______________________________________________ >>> caiman-discuss mailing list >>> caiman-discuss at opensolaris.org >>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >>> >>> >> _______________________________________________ >> caiman-discuss mailing list >> caiman-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >> > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >
